优化

internal/biz/menu.go

@@ -59,6 +59,11 @@ type MenuRepo interface {
 	List(context.Context) ([]*Menu, error)
 	SetAuthorityMenus(context.Context, uint, []uint) error
 	AuthorityMenuIDs(context.Context, uint) ([]uint, error)
+	// ListAuthorityMenus returns the base menus assigned to the target
+	// authority. Unlike List, it must not apply the current actor's strict
+	// menu filter: the administration endpoint is explicitly querying another
+	// role's assignments.
+	ListAuthorityMenus(context.Context, uint) ([]*Menu, error)
 	MenuRoleIDs(context.Context, uint) ([]uint, error)
 	DefaultRouterRoleIDs(context.Context, uint) ([]uint, error)
 	SetMenuRoles(context.Context, uint, []uint) error
@@ -79,10 +84,10 @@ func (uc *MenuUsecase) Tree(ctx context.Context) ([]*Menu, error) {
 	}
 	byID := make(map[uint]*Menu, len(items))
 	for _, item := range items {
-		item.Children = []*Menu{}
+		item.Children = nil
 		byID[item.ID] = item
 	}
-	roots := make([]*Menu, 0)
+	var roots []*Menu
 	for _, item := range items {
 		if parent := byID[item.ParentID]; parent != nil {
 			parent.Children = append(parent.Children, item)
@@ -114,31 +119,11 @@ func (uc *MenuUsecase) SetAuthorityMenus(ctx context.Context, authorityID uint,
 }
 
 func (uc *MenuUsecase) AuthorityMenus(ctx context.Context, authorityID uint) ([]*Menu, error) {
-	ids, err := uc.repo.AuthorityMenuIDs(ctx, authorityID)
+	items, err := uc.repo.ListAuthorityMenus(ctx, authorityID)
 	if err != nil {
 		return nil, err
 	}
-	items, err := uc.repo.List(ctx)
-	if err != nil {
-		return nil, err
-	}
-	selected := make(map[uint]struct{}, len(ids))
-	for _, id := range ids {
-		selected[id] = struct{}{}
-	}
-	result := make([]*Menu, 0, len(ids))
-	for _, item := range items {
-		if _, ok := selected[item.ID]; ok {
-			// The authority-menu endpoint returns menu relations only. Keep its
-			// existing contract: button details are loaded by the dedicated
-			// authority-button endpoints. The compatible query does not preload either
-			// relation here, so parameters must remain absent as well.
-			item.Buttons = nil
-			item.Parameters = nil
-			result = append(result, item)
-		}
-	}
-	return result, nil
+	return items, nil
 }
 
 func (uc *MenuUsecase) RoleIDs(ctx context.Context, menuID uint) ([]uint, error) {