优化

internal/biz/dictionary.go

@@ -37,6 +37,7 @@ type DictionaryDetailRepo interface {
 	FindDictionaryDetail(context.Context, uint) (*DictionaryDetail, error)
 	ListDictionaryDetails(context.Context, int, int, DictionaryDetailFilter) ([]*DictionaryDetail, int64, error)
 	DictionaryDetailTree(context.Context, uint, string) ([]*DictionaryDetail, error)
+	DictionaryDetailsByParent(context.Context, uint, *uint, bool) ([]*DictionaryDetail, error)
 }
 
 type Dictionary struct {
@@ -78,38 +79,5 @@ func (uc *DictionaryUsecase) ImportDictionary(ctx context.Context, dictionary *D
 }
 
 func (uc *DictionaryUsecase) DictionaryDetailsByParent(ctx context.Context, dictionaryID uint, parentID *uint, includeChildren bool) ([]*DictionaryDetail, error) {
-	items, _, err := uc.ListDictionaryDetails(ctx, 0, 0, DictionaryDetailFilter{DictionaryID: dictionaryID})
-	if err != nil {
-		return nil, err
-	}
-	direct := make([]*DictionaryDetail, 0)
-	for _, item := range items {
-		if (parentID == nil && item.ParentID == nil) || (parentID != nil && item.ParentID != nil && *item.ParentID == *parentID) {
-			direct = append(direct, item)
-		}
-	}
-	if !includeChildren {
-		return direct, nil
-	}
-	children := make(map[uint][]*DictionaryDetail)
-	for _, item := range items {
-		item.Children = []*DictionaryDetail{}
-		if item.ParentID != nil {
-			children[*item.ParentID] = append(children[*item.ParentID], item)
-		}
-	}
-	var attach func(*DictionaryDetail)
-	attach = func(item *DictionaryDetail) {
-		item.Children = children[item.ID]
-		if item.Children == nil {
-			item.Children = []*DictionaryDetail{}
-		}
-		for _, child := range item.Children {
-			attach(child)
-		}
-	}
-	for _, item := range direct {
-		attach(item)
-	}
-	return direct, nil
+	return uc.DictionaryRepo.DictionaryDetailsByParent(ctx, dictionaryID, parentID, includeChildren)
 }