优化结构

2026-08-28 10:51:19 +08:00
parent fec3820464
commit 5b17f47141
12 changed files with 63 additions and 31 deletions
@@ -140,6 +140,23 @@ func TestLoginRecordsSuccessBeforeMultipointCacheFailure(t *testing.T) {
 	}
 }

+func TestLoginResultDoesNotExposePasswordHash(t *testing.T) {
+	hash, err := bcrypt.GenerateFromPassword([]byte("secret"), bcrypt.MinCost)
+	if err != nil {
+		t.Fatal(err)
+	}
+	user := &User{ID: 1, Username: "admin", Password: string(hash), AuthorityID: 888, Enable: 1}
+	security := NewSecurityUsecase(&authenticationSecurityRepo{}, &authenticationCache{}, &authenticationSettings{}, nil)
+	uc := NewAuthenticationUsecase(NewUserUsecase(&authenticationUserRepo{user: user}), security, &authenticationIssuer{}, nil)
+	result, err := uc.Login(context.Background(), &LoginAttempt{Username: "admin", Password: "secret", IP: "127.0.0.1"})
+	if err != nil {
+		t.Fatal(err)
+	}
+	if result.User.Password != "" {
+		t.Fatalf("authentication result retained password hash")
+	}
+}
+
 func TestRecordLoginAllowsMissingAuditRecorder(t *testing.T) {
 	uc := &AuthenticationUsecase{}
 	uc.recordLogin(context.Background(), &LoginAttempt{Username: "admin"}, false, "failed", 0)