对接

internal/server/websocket_auth_test.go

@@ -30,7 +30,7 @@ func (s *websocketAuthStub) AuthenticateToken(_ context.Context, token string) (
 
 var _ middleware.TokenAuthenticator = (*websocketAuthStub)(nil)
 
-func TestWebSocketRouteRequiresAndAcceptsLoginToken(t *testing.T) {
+func TestWebSocketRouteAcceptsAnonymousAndAuthenticatedViewers(t *testing.T) {
 	store := runtimeconfig.NewStore()
 	raw, err := json.Marshal(map[string]any{"path": "/ws"})
 	if err != nil {
@@ -46,26 +46,35 @@ func TestWebSocketRouteRequiresAndAcceptsLoginToken(t *testing.T) {
 	auth := &websocketAuthStub{claims: &system.AuthClaims{ID: 7}}
 	engine := NewGinEngineWithRuntime(config.NewStore(&config.Config{Admin: &config.Admin{}}), nil, auth, nil, nil, nil, "test", nil, ws)
 
-	unauthorized := httptest.NewRecorder()
-	engine.ServeHTTP(unauthorized, httptest.NewRequest(http.MethodGet, "/ws", nil))
-	if unauthorized.Code != http.StatusUnauthorized {
-		t.Fatalf("unauthorized websocket status=%d body=%s", unauthorized.Code, unauthorized.Body.String())
-	}
-
 	httpServer := httptest.NewServer(engine)
 	defer httpServer.Close()
-	wsURL := "ws" + strings.TrimPrefix(httpServer.URL, "http") + "/ws?token=login-token"
-	connection, response, err := gorillawebsocket.DefaultDialer.Dial(wsURL, nil)
+	baseURL := "ws" + strings.TrimPrefix(httpServer.URL, "http") + "/ws"
+	anonymous, response, err := gorillawebsocket.DefaultDialer.Dial(baseURL, nil)
 	if response != nil && response.Body != nil {
 		_ = response.Body.Close()
 	}
 	if err != nil {
-		t.Fatalf("authorized websocket handshake failed: %v", err)
+		t.Fatalf("anonymous websocket handshake failed: %v", err)
 	}
-	if connection == nil {
-		t.Fatal("authorized websocket handshake returned nil connection")
+	if anonymous == nil {
+		t.Fatal("anonymous websocket handshake returned nil connection")
 	}
-	_ = connection.Close()
+	_ = anonymous.Close()
+	if auth.got != "" {
+		t.Fatalf("anonymous websocket unexpectedly authenticated token=%q", auth.got)
+	}
+
+	authenticated, response, err := gorillawebsocket.DefaultDialer.Dial(baseURL+"?token=login-token", nil)
+	if response != nil && response.Body != nil {
+		_ = response.Body.Close()
+	}
+	if err != nil {
+		t.Fatalf("authenticated websocket handshake failed: %v", err)
+	}
+	if authenticated == nil {
+		t.Fatal("authenticated websocket handshake returned nil connection")
+	}
+	_ = authenticated.Close()
 	if auth.got != "login-token" {
 		t.Fatalf("websocket auth token=%q, want login-token", auth.got)
 	}